Conversation
Signed-off-by: Derek Nola <derek.nola@suse.com>
cioionut
pushed a commit
to cioionut/k3s-ansible
that referenced
this pull request
Mar 6, 2026
…io#489) Signed-off-by: Derek Nola <derek.nola@suse.com> Signed-off-by: Ionut <ionutnciocoiu@gmail.com>
alluabhijeet
pushed a commit
to alluabhijeet/k3s-ansible
that referenced
this pull request
Apr 19, 2026
feat: contributing guide
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
General Notes
A long term goal of mine as maintainer is to remove the entire concept of Jinja2 templating from this repo. By more heavily utilizing the default nature of the http://get.k3s.io install script, we don't need to manage and replace both the service and env files around an install or upgrade.
This is a step towards adding complete support for openrc service manager based OSes. Since the agent role has previously had its jinga2 template removed, I decided to start with implementing the openrc feature with just agents.
I also took this opportunity to move towards the goal of consolidating the update and site playbooks. I'm currently not completely sold on the idea of completely removing the upgrade playbook, but there is significant simplification that should take place for the upgrade role. Now this PR may seem like I'm "adding" more lines to the role right now, but when I start ripping out the templating for servers, the entire role will become more simplified. Baby steps.
Changes
Linked Issues
#463
#485