Open
Conversation
Before this commit when handling OmniKassa2::OmnikassaError it might have handled Omnikassa2::HttpError's. This might have been the (unlikely) case where there's an unsuccessful response containing valid JSON. With HttpError no longer inheriting from OmnikassaError this would break. Now ApiError takes it place until 2.0. A deprecation warning is shown (also to those handling JSON::ParserError) to migrate to HttpError or OmnikassaError before 2.0.
8 tasks
rbr
reviewed
Jan 19, 2026
Member
rbr
left a comment
There was a problem hiding this comment.
Wouldn't it be easier to just release the changes on master as a 2.0 release?
What's the added benefit of making a 1.1 for which there might be some risk of breaking something somewhere?
(I appreciate the effort put in to cover the situation we see, but with all the changes I'd think it's easier to not bother with a 1.x release.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this commit when handling OmniKassa2::OmnikassaError it might have handled Omnikassa2::HttpError's.
This might have been the (unlikely) case where there's an unsuccessful response containing valid JSON.
With HttpError no longer inheriting from OmnikassaError this would break. Now ApiError takes it place until 2.0.
A deprecation warning is shown (also to those handling JSON::ParserError) to migrate to HttpError or OmnikassaError before 2.0.
Code Review
Please consider the following checklist when reviewing this Pull Request.
More background and details here.