ci: assert kubeadm exposes the upgrade-path surface per minor#11
Merged
Conversation
After building each per-minor image, run the bundled kubeadm and assert it exposes exactly the subcommands/flags the upgrade path drives, so an upstream removal/rename is caught on every PR before it breaks an upgrade at runtime: - upgrade apply: --yes, --certificate-renewal - upgrade node: subcommand exists - init phase kubelet-start: --config (ADR-12-R1 API-free kubelet repair) - init phase upload-certs: --config (cert-key via config, never argv -- the mint keystone, ADR-11 #3 / ADR-12 B3) Runs inside the images CI already builds (1.34/1.35/1.36) -- no release/tag needed. Pure edge logic (accept +1 minor; refuse skip/downgrade/out-of-window) is already covered by TestUpgradePath; the full live upgrade stays the libvirt smoke. Verified the flags against real kubeadm v1.35.5 before committing. Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: William Rizzo <william.rizzo@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the U-N backlog item: lock the "the shipped kubeadm supports what the upgrade path calls" assumption on every PR, across the supported window — no release tag required.
After CI builds each per-minor image (1.34/1.35/1.36), a new step runs the bundled
kubeadmand asserts the subcommands/flags the provider drives for upgrades:upgrade apply:--yes,--certificate-renewalupgrade node: subcommand existsinit phase kubelet-start:--config(ADR-12-R1 API-free kubelet-config repair)init phase upload-certs:--config(cert-key via config, never argv — the mint keystone)An upstream removal/rename of any of these now fails CI before it can break an upgrade at runtime.
Coverage split
TestUpgradePath+ thePlantable in the fasttestgate.Verified the flags against real
kubeadm v1.35.5before committing. Reuses the existing image-build matrix; no release/tag involved.🤖 Generated with Claude Code