fix(release): attest bundled control-plane images as a custom predicate (ADR-16 P5)#28
Merged
Merged
Conversation
…te (ADR-16 P5) The v0.3.0 release failed at 'Attest bundled control-plane image SBOM': actions/attest-sbom rejected the hand-rolled CycloneDX with 'Unsupported SBOM format' -- its SBOM-format detector is stricter than the CycloneDX spec (the doc validates fine under cyclonedx-cli). Rather than chase that detector's quirks, attest the baked-in images.lock DIRECTLY as a custom in-toto predicate via generic actions/attest: images.lock IS the authoritative ref->digest->verified/verifyReason record, and a generic predicate bypasses SBOM-format detection entirely -- more robust and future-proof, and it still records exactly which control-plane images (by digest) the release baked and at what trust level (B5 intent preserved). - release.yml: replace the CycloneDX-generate + attest-sbom steps with an extract-images.lock step + actions/attest@v2 (predicate-type https://kairos.io/attestations/bundled-control-plane-images/v1, predicate-path images.lock). Action SHA-pinned (# v2), consistent with #4203. - Remove build/gen-bundled-sbom.py (no longer used). The image + binary SBOM attestations (syft-generated CycloneDX) are unchanged -- those pass the detector and are proven since v0.2.2; only the hand-rolled bundled SBOM tripped it. Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: William Rizzo <william.rizzo@gmail.com>
…P5 B5) Consumers must pass the custom predicate-type explicitly to verify the pre-bundled control-plane image set (per security-architect follow-up on PR #28): gh attestation verify ... --predicate-type \ https://kairos.io/attestations/bundled-control-plane-images/v1 Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: William Rizzo <william.rizzo@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The v0.3.0 release failed at
Attest bundled control-plane image SBOM:actions/attest-sbom's SBOM-format detector rejected the hand-rolled CycloneDXpredicate (the doc is spec-valid —
cyclonedx-cli validatepasses it; the action'sdetector is simply stricter/opaque). Everything else in the release succeeded
(images pushed, provenance + image SBOM + binary attestations).
Fix (robust / future-proof)
Stop depending on the SBOM-format detector. Attest the baked-in
images.lockdirectly as a custom in-toto predicate via generic
actions/attest:images.lockis the authoritative record —ref → digest → verified → verifyReasonfor every bundled control-plane image — so attesting it directly isfaithful to (arguably better than) ADR-16 B5's intent: each released image
attests exactly which control-plane images it baked, by digest, and at what trust
level (cosign-verified vs digest-pinned-only).
predicate-type+predicate-pathaccepts arbitrary JSON — noSBOM-format detection to trip over. Verifiable with
gh attestation verify <image> --predicate-type https://kairos.io/attestations/bundled-control-plane-images/v1.Changes
release.yml: replace the CycloneDX-generate +attest-sbomsteps with anextract-
images.lockstep +actions/attest@v2(SHA-pinned# v2, consistentwith #4203).
build/gen-bundled-sbom.py(no longer used).The image + binary SBOM attestations (syft-generated CycloneDX) are unchanged —
those pass the detector and are proven since v0.2.2; only the hand-rolled bundled
SBOM tripped it.
Validation
release.ymlvalid YAML, all actions SHA-pinned;actions/attest@v2confirmed toaccept
predicate-type+predicate-path. Go gates unaffected (workflow-onlychange + script removal). The attest step itself runs only in a tagged release
(OIDC) — this is the re-cut that exercises it.