Skip to content

Add trim parameter for gaps aggregator #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ae3e wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Add trim parameter for gaps aggregator #99

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions src/main/java/org/kairosdb/client/builder/aggregator/SamplingAggregator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,9 @@ public class SamplingAggregator extends Aggregator
@SerializedName("start_time")
private Long startTime;

@SerializedName("trim")
private Boolean trim;

public SamplingAggregator(String name, long value, TimeUnit unit)
{
super(name);
Expand All @@ -57,6 +60,19 @@ public TimeUnit getUnit()
return sampling.unit;
}

/**
* To trim off empty ranges before and after the actual data (issue #453 - https://github.com/kairosdb/kairosdb/issues/453)
* Default value is false.
*
* @return the SamplingAggregator
*/
public SamplingAggregator withTrim()
{
trim = true;

return this;
}

/**
* <p>
* Alignment based on the sampling size. For example if your sample size is either milliseconds,
Expand Down Expand Up @@ -163,6 +179,11 @@ public SamplingAggregator withAlignment(Boolean alignStartTime, Boolean alignSam
return this;
}

public Boolean isTrim()
{
return trim != null ? trim : false;
}

public Boolean isAlignStartTime()
{
return alignStartTime != null ? alignStartTime : false;
Expand Down
11 changes: 11 additions & 0 deletions src/test/java/org/kairosdb/client/builder/AggregatorFactoryTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,17 @@ public void test_createPercentileAggregator()
assertThat(aggregator.getUnit(), equalTo(TimeUnit.DAYS));
}

@Test
public void test_createDataGapsMarkingAggregator()
{
SamplingAggregator aggregator = AggregatorFactory.createDataGapsMarkingAggregator(3, TimeUnit.DAYS).withTrim();

assertThat(aggregator.getName(), equalTo("gaps"));
assertThat(aggregator.isTrim(),equalTo(true));
assertThat(aggregator.getValue(), equalTo(3));
assertThat(aggregator.getUnit(), equalTo(TimeUnit.DAYS));
}

@Test
public void test_createRateAggregator()
{
Expand Down