fix(SUP-51302): fix _setSrc() returning wrong promise causing iOS playback failure#868
Open
ravitshalem with Copilot wants to merge 1 commit into
Open
fix(SUP-51302): fix _setSrc() returning wrong promise causing iOS playback failure#868ravitshalem with Copilot wants to merge 1 commit into
ravitshalem with Copilot wants to merge 1 commit into
Conversation
…yback failure Agent-Logs-Url: https://github.com/kaltura/playkit-js/sessions/30e0b578-2e66-46c0-938b-a8074c2a4592 Co-authored-by: ravitshalem <31099969+ravitshalem@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
ravitshalem
March 30, 2026 16:58
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Changes
Root cause:
_setSrc()inNativeAdapterwas returningrequestFilterPromise— the original request-filter promise — instead of the fully chained promise that setsvideoElement.srcand fetches the HLS manifest. The chained.then()block was completely detached (fire-and-forget), so the caller inload()received a promise that resolved immediately, before the src was ever set. This causedvideoElement.load()to be called on an empty video element, preventing playback on iOS whereNativeAdapteris used for native HLS.Changes:
_setSrc()soload()correctly waits forvideoElement.srcto be set before callingvideoElement.load()._setSrc()is called more than once (e.g. on video-track switch or decode-error recovery).CheckLists