Skip to content

Replaced Travis-CI with GitHub Actions.#2

Draft
dblock wants to merge 1 commit into
kaminari:masterfrom
dblock:ci
Draft

Replaced Travis-CI with GitHub Actions.#2
dblock wants to merge 1 commit into
kaminari:masterfrom
dblock:ci

Conversation

@dblock

@dblock dblock commented Jun 22, 2024

Copy link
Copy Markdown

I'm using kaminari-grape in https://github.com/dblock/slack-gamebot and hit #1. Attempting to revive CI here.

I tried to lock back down to older versions of gems to get a baselines, but can't get CI to pass. This is coming from Kaminari proper, so not sure why.

========================================================================================================================================================================================================================================================================================================================================================
Error: test: #param_name(PaginatorHelperTest): ArgumentError: wrong number of arguments (given 2, expected 1)
/Users/dblock/.rvm/gems/ruby-3.2.1/bundler/gems/kaminari-02b179af444d/kaminari-core/lib/kaminari/helpers/tags.rb:19:in `initialize'
/Users/dblock/.rvm/gems/ruby-3.2.1/bundler/gems/kaminari-02b179af444d/kaminari-core/lib/kaminari/helpers/paginator.rb:57:in `new'
/Users/dblock/.rvm/gems/ruby-3.2.1/bundler/gems/kaminari-02b179af444d/kaminari-core/lib/kaminari/helpers/paginator.rb:57:in `page_tag'
/Users/dblock/.rvm/gems/ruby-3.2.1/bundler/gems/kaminari-02b179af444d/kaminari-core/test/helpers/helpers_test.rb:44:in `block in <class:PaginatorHelperTest>'
========================================================================================================================================================================================================================================================================================================================================================
E
========================================================================================================================================================================================================================================================================================================================================================
Error: test: when params has form params(PaginatorHelperTest::#params): ArgumentError: wrong number of arguments (given 2, expected 1)
/Users/dblock/.rvm/gems/ruby-3.2.1/bundler/gems/kaminari-02b179af444d/kaminari-core/lib/kaminari/helpers/tags.rb:19:in `initialize'
/Users/dblock/.rvm/gems/ruby-3.2.1/bundler/gems/kaminari-02b179af444d/kaminari-core/lib/kaminari/helpers/paginator.rb:57:in `new'
/Users/dblock/.rvm/gems/ruby-3.2.1/bundler/gems/kaminari-02b179af444d/kaminari-core/lib/kaminari/helpers/paginator.rb:57:in `page_tag'
/Users/dblock/.rvm/gems/ruby-3.2.1/bundler/gems/kaminari-02b179af444d/kaminari-core/test/helpers/helpers_test.rb:38:in `block (2 levels) in <class:PaginatorHelperTest>'
========================================================================================================================================================================================================================================================================================================================================================
E
========================================================================================================================================================================================================================================================================================================================================================
Error: test: when params has no form params(PaginatorHelperTest::#params): ArgumentError: wrong number of arguments (given 2, expected 1)
/Users/dblock/.rvm/gems/ruby-3.2.1/bundler/gems/kaminari-02b179af444d/kaminari-core/lib/kaminari/helpers/tags.rb:19:in `initialize'
/Users/dblock/.rvm/gems/ruby-3.2.1/bundler/gems/kaminari-02b179af444d/kaminari-core/lib/kaminari/helpers/paginator.rb:57:in `new'
/Users/dblock/.rvm/gems/ruby-3.2.1/bundler/gems/kaminari-02b179af444d/kaminari-core/lib/kaminari/helpers/paginator.rb:57:in `page_tag'
/Users/dblock/.rvm/gems/ruby-3.2.1/bundler/gems/kaminari-02b179af444d/kaminari-core/test/helpers/helpers_test.rb:30:in `block (2 levels) in <class:PaginatorHelperTest>'
=====================================================================================================================================================================================

Signed-off-by: Daniel (dB.) Doubrovkine <dblock@dblock.org>
@yuki24

yuki24 commented Jun 22, 2024

Copy link
Copy Markdown
Member

Thanks for this! (also, hi 👋)

Looking at .travis.yml the test suite has not been run in CI at all. I'll look into it tomorrow and see if I can run it locally and try to get it working.

@dblock

dblock commented Jun 22, 2024

Copy link
Copy Markdown
Author

You can see the GHA being run in my fork, https://github.com/dblock/kaminari-grape/actions, they fail as described above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants