Fixed an issue where the URL is not correctly created if "[]" is included in the query parameter#3
Open
MiuraSeiya wants to merge 3 commits into
Open
Fixed an issue where the URL is not correctly created if "[]" is included in the query parameter#3MiuraSeiya wants to merge 3 commits into
MiuraSeiya wants to merge 3 commits into
Conversation
URL could not be created correctly when `[]`is included in query paramerter
Member
|
I don't think I understand your isssue. Could you add a test case? |
Author
|
I understand. Add a test case. |
Author
|
@yuki24 I added a test case, so please check. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #2
At
L92ofkaminari-sinatra / lib / kaminari / helpers / sinatra_helpers.rb,The problem was corrected by deleting any parameter whose key is "[]".