fix extra parameters params for the links#6
Open
kevinhughes27 wants to merge 1 commit into
Open
Conversation
Author
|
Travis is failing with the same error I see locally 😞 |
Author
|
Just noticed I am still on my branch for this, any interest in getting this merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm using kaminari with sinatra on a project and I need to use extra parameters with the pagination links. The kaminari documentation describes this here https://github.com/kaminari/kaminari#extra-parameters-params-for-the-links. Unfortunately this doesn't seem to be working with the sinatra gem in my project (I didn't test a vanilla application).
I did some digging and this patch fixed the problem for me. I'm not sure it is the best solution since merging the idea of
current_paramsandextra_paramsmight be confusing but this was the fix with the least impact on the existing code so I thought I would start here. I'm happy to go further with some guidance from a maintainer.Also the tests crashed on my machine so hopefully travis still runs.