fix: fix automatic capabilities conversion from JWP to W3C#277
Open
gkalpak wants to merge 3 commits intokarma-runner:masterfrom
Open
fix: fix automatic capabilities conversion from JWP to W3C#277gkalpak wants to merge 3 commits intokarma-runner:masterfrom
gkalpak wants to merge 3 commits intokarma-runner:masterfrom
Conversation
gkalpak
force-pushed
the
fix-process-config-jwp
branch
from
c283d97 to
669abe6
Compare
The `processConfig()` function attempts to convert capabilities from the deprecated JWP format to the new standard W3C one. Fix the logic for detecting when capabilites are in JWP format. (Previously, the logic was inverted.) Also, make sure that the `sauce:options` property is correctly populated in both cases.
gkalpak
force-pushed
the
fix-process-config-jwp
branch
from
669abe6 to
34d82d0
Compare
Update the automatic conversion of capabilities from JWP to W3C format to exclude Internet Explorer 9. Although according to the [SauceLabs docs][1] all versions of Internet Explorer support the new W3C capabilities format, in reality only versions >=10 do. SauceLabs support has confirmed this and said that until the docs are fixed, _"the [Platform Configurator][2] would be the most reliable reference for compliant capabilities"_. Indeed, in the Platform Configurator, IE 9 only offers the option to select `JWP (legacy)` as the capabilities format. [1]: https://docs.saucelabs.com/dev/w3c-webdriver-capabilities/index.html#browser-compatibility [2]: https://saucelabs.com/platform/platform-configurator
Use the value of `appium:platformVersion` (if present) in `browserName`. Since the [capabilities config when using Appium][1] does not include a browser version, but only the platform version, including the value of `appium:platformVersion` in `browserName` is essential in order to be able to identify which platform the logs refer to. [1]: https://docs.saucelabs.com/mobile-apps/automated-testing/appium/virtual-devices/#ios-code-examples
gkalpak
force-pushed
the
fix-process-config-jwp
branch
from
34d82d0 to
a00e886
Compare
gkalpak
changed the title
Splaktar
reviewed
Oct 28, 2022
Splaktar
left a comment
Splaktar
left a comment
There was a problem hiding this comment.
I don't doubt that this fixes the issue, but I have some questions about aligning the comments and deletion of capabilities with the isW3C check.
src/process-config.ts
Outdated
|
|
||
| // transform JWP capabilities into W3C capabilities for backward compatibility | ||
| if (isW3C(args)) { | ||
| if (!isW3C(args)) { |
There was a problem hiding this comment.
This change doesn't seem to align with the comments above or below.
Why would you "delete JWP capabilities" if you are in JWP mode?
Author
There was a problem hiding this comment.
If the capabilities are in the old JWP format, then they are converted to the new W3C format (inside the if block). Essentially, JWP's version and platform properties are converted to W3C's browserVersion and platformName properties. At the end, the JWP properties, version and platform are deleted from the args object (since they are not needed any more).
Does that make sense?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A couple of fixes mainly related to the automatic conversion of capabilities from the legacy JWP format to the new W3C.
See the individual commit messages for details.