Fix type check of the kcl-language-server of missing required attributes - #1928
Open
liorfr-monday wants to merge 6 commits into
Open
Fix type check of the kcl-language-server of missing required attributes#1928liorfr-monday wants to merge 6 commits into
liorfr-monday wants to merge 6 commits into
Conversation
liorfr-monday
force-pushed
the
main
branch
5 times, most recently
from
April 23, 2025 19:54
856a452 to
af3e97f
Compare
Contributor
|
Thanks for the contribution. The CI failed, and you can format all your rust code. |
Author
Formatted. |
Signed-off-by: Lior Franko <liorfr@monday.com>
Signed-off-by: Lior Franko <liorfr@monday.com>
Signed-off-by: Lior Franko <liorfr@monday.com>
Signed-off-by: Lior Franko <liorfr@monday.com>
Author
|
I fixed the error print and moved it to the nested item. |
Contributor
|
The unit test CI still failed. : ( |
Contributor
|
The CI still failed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
No
2. What is the scope of this PR (e.g. component or file name):
kcl/kclvm/tools/src/LSP/src/validator.rs
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
Improve the type check when working from IDE.
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
N
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:
Before:
After