feat: add toast notification component#9
Open
GautamKumarOffical wants to merge 2 commits into
Open
Conversation
Adds a toast notification component with three variants: - success (green/ok) - warning (amber/warn) - error (red/hot) Uses design tokens from tokens.css for consistent styling. Closes kcolbchain#7
Contributor
|
Welcome to kcolbchain, @GautamKumarOffical — glad you're here. 🌱 Here's what happens from this PR:
While you wait:
What happens after your first merge
Thanks for writing the code. We're building this to last. |
Contributor
|
🤖 Audit verdict: Toast component uses innerHTML to render user-supplied message parameter, creating a potential XSS vector if not sanitized at call sites. Risks flagged:
Audited by the kcolbchain PR pipeline. See pipeline docs. |
Replace innerHTML with textContent for the message parameter to prevent potential XSS attacks from unsanitized user input. Use proper DOM API (createElement, textContent, addEventListener) instead of string interpolation with innerHTML. Signed-off-by: Gautam Kumar <gautamkumarofficial@users.noreply.github.com>
Author
|
Fixed the XSS issue flagged by the audit. Replaced |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a toast notification component with three variants to the brand design system.
Closes #7
What this PR does
Creates a toast notification component that:
tokens.cssfor consistent stylingFiles added
components/toast.css— Toast styles using design tokenscomponents/toast.js— Toast component logicUsage
Acceptance Criteria
tokens.css