Skip to content

fix: removes duplicated definition of nginx ingress class on ingress-nginx.yaml #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jpsuazoWS wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: removes duplicated definition of nginx ingress class on ingress-nginx.yaml #174

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
89a5acb
bugfix: removes duplicated definition of nginx ingress class on ingre…
jpsuazoWS Aug 6, 2025
aef2887
Bump versions
jpsuazoWS Aug 8, 2025
a1538a5
Merge branch 'main' into nginx-ingress-template-bugfix
jpsuazoWS Oct 3, 2025
02ebdfb
Merge branch 'main' into nginx-ingress-template-bugfix
jpsuazoWS Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/keep/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ version: 0.1.93
description: Keep Helm Chart
type: application
icon: https://platform.keephq.dev/_next/image?url=%2Fkeep.png&w=48&q=75
appVersion: 0.45.4
appVersion: 0.45.5
deprecated: false
annotations:
app: keep
Expand Down
1 change: 0 additions & 1 deletion charts/keep/templates/ingress-nginx.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ metadata:
app.kubernetes.io/component: networking
annotations:
{{- if or (eq .Values.global.ingress.className "nginx") (eq .Values.global.ingress.classType "nginx") }}
kubernetes.io/ingress.class: {{ .Values.global.ingress.className }}
nginx.ingress.kubernetes.io/proxy-read-timeout: "3600"
nginx.ingress.kubernetes.io/proxy-send-timeout: "3600"
nginx.ingress.kubernetes.io/proxy-connect-timeout: "3600"
Expand Down