fix(helm): add explicit namespace to all resource templates#186
Open
Smana wants to merge 1 commit intokeephq:mainfrom
Open
fix(helm): add explicit namespace to all resource templates#186Smana wants to merge 1 commit intokeephq:mainfrom
Smana wants to merge 1 commit intokeephq:mainfrom
Conversation
Add `namespace: {{ include "keep.namespace" . }}` to all Kubernetes
resource templates that were missing it. This ensures proper namespace
handling when deploying via tools like kustomize that rely on namespace
being explicitly set in resource metadata.
Resources updated:
- ServiceAccount
- Deployments (backend, frontend, websocket, database)
- Services (backend, frontend, websocket, database)
- HorizontalPodAutoscalers
- Secrets and ConfigMaps
- PersistentVolumeClaim
- CronJob (db-cleanup)
- Job (delete-secret)
- Ingresses (nginx, haproxy, traefik)
- Routes (OpenShift)
Also updated GKE BackendConfig and Traefik Middleware templates to use
the `keep.namespace` helper instead of `.Release.Namespace` for
consistency.
Note: PersistentVolume (db-pv.yaml) is intentionally excluded as it is
a cluster-scoped resource that does not have a namespace.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📑 Description
Add
namespace: {{ include "keep.namespace" . }}to all Kubernetes resource templates that were missing it. This ensures proper namespace handling when deploying via tools like kustomize that rely on namespace being explicitly set in resource metadata.Resources updated:
Also updated GKE BackendConfig and Traefik Middleware templates to use the
keep.namespacehelper instead of.Release.Namespacefor consistency.Note: PersistentVolume (db-pv.yaml) is intentionally excluded as it is a cluster-scoped resource that does not have a namespace.
✅ Checks