[Harsh Review] Add PrintNumbers.cs - #3
Conversation
kendaleiv
left a comment
kendaleiv
left a comment
There was a problem hiding this comment.
Please address my comments.
Add a PR description, it's blank. Amend your commit to include the same text.
| @@ -0,0 +1,10 @@ | |||
| public class PrintNumbers | |||
| { | |||
| public void Print() | |||
There was a problem hiding this comment.
There are no tests for this method. Please add them.
| @@ -0,0 +1,10 @@ | |||
| public class PrintNumbers | |||
| { | |||
| public void Print() | |||
There was a problem hiding this comment.
This method isn't invoked.
| @@ -0,0 +1,10 @@ | |||
| public class PrintNumbers | |||
| { | |||
| public void Print() | |||
There was a problem hiding this comment.
This method could be static.
| @@ -0,0 +1,10 @@ | |||
| public class PrintNumbers | |||
There was a problem hiding this comment.
This class could be static.
| { | ||
| public void Print() | ||
| { | ||
| for (var i = 0; i < 10; i++) |
There was a problem hiding this comment.
This shouldn't only count to 9, it should accept the number to count to as a parameter.
| { | ||
| for (var i = 0; i < 10; i++) | ||
| { | ||
| System.Console.WriteLine(i); |
There was a problem hiding this comment.
Move System to a using.
| System.Console.WriteLine(i); | ||
| } | ||
| } | ||
| } No newline at end of file |
There was a problem hiding this comment.
This file doesn't end with a newline.
| @@ -0,0 +1,10 @@ | |||
| public class PrintNumbers | |||
| @@ -0,0 +1,10 @@ | |||
| public class PrintNumbers | |||
| { | |||
| public void Print() | |||
There was a problem hiding this comment.
There's no documentation for how to use this.
| @@ -0,0 +1,10 @@ | |||
| public class PrintNumbers | |||
There was a problem hiding this comment.
Rename to DisplayNumbers. Rename the method. Rename the file. Update the PR title.
1 participant
No description provided.