Added main and browser fields for npm installation#88
Open
amilajack wants to merge 1 commit intokennethcachia:masterfrom
Open
Added main and browser fields for npm installation#88amilajack wants to merge 1 commit intokennethcachia:masterfrom
amilajack wants to merge 1 commit intokennethcachia:masterfrom
Conversation
This allows the package to be installed with npm directly from github as a dependency. Added this because there is no npm support yet.
felipekm
approved these changes
May 23, 2017
shri3k
approved these changes
Sep 2, 2017
shri3k
reviewed
Sep 5, 2017
shri3k
left a comment
There was a problem hiding this comment.
I accidentally approved this earlier but when I tested this in my repo I got some error.
This might need more than just changes in package.json.
I'm thinking something like the following should be added if people are using CJS instead of just AMD.
if (typeof define === 'function' && define.amd) {
define(factory);
} else if (typeof module === 'object' && module.exports) {
module.exports = root.BackgroundCheck;
} else {
root.BackgroundCheck = factory(root);
}Any thoughts?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@kennethcachia This allows the package to be installed with npm directly from github as a dependency. Added this because there is no npm support yet.