Use exif.js to extract full exif tags#8
Open
nickw1 wants to merge 7 commits intokennydude:masterfrom
nickw1:master
Open
Use exif.js to extract full exif tags#8nickw1 wants to merge 7 commits intokennydude:masterfrom nickw1:master
nickw1 wants to merge 7 commits intokennydude:masterfrom
nickw1:master
Conversation
…adingDegrees property
… on IE, even with that fixed, for reasons currently unknown.
… IE10 though will not work in older IE at all
…t done originally, maybe I'll find out soon ;-)
…ications might not want to use it, leave it up to the application
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change involves the use of the exif.js library (https://github.com/jseidelin/exif-js) to pull out full EXIF data for the photosphere. The rationale for this is that it might be desirable to obtain the latitude and longitude where the photosphere is taken, for example for displaying the photospheres on the map. I also store the "PoseHeadingDegrees" GPano property in the exif object; this has applications including the possibility of linking photospheres to create virtual tours in which the user can navigate from one photosphere to the next, with direction arrows superimposed on the photosphere.
EDIT: just realised this breaks in IE. The xmlHTTP.overrideMimeType() is not supported in IE. I've modified my own branch to only use this if supported, but then IE breaks somewhere else, in the final callback() call, with some random system error. So it's best you don't pull this change in just yet.