[chore] DuckDB demo app - #2942
Open
igorDykhta wants to merge 25 commits into
Open
Conversation
✅ Deploy Preview for kepler-duckdb ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
ilyabo
approved these changes
Jan 27, 2025
igorDykhta
force-pushed
the
igr/duckdb-demo-branch
branch
from
January 28, 2025 18:47
5ea5b9e to
338395f
Compare
Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
igorDykhta
force-pushed
the
igr/duckdb-demo-branch
branch
from
February 18, 2025 16:55
b6ef1c7 to
bcb169d
Compare
… top; filter out trips example Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR configures a DuckDB demo application by enabling DuckDB integration, disabling incompatible features, and customizing the UI for a preview deployment. The changes focus on making the demo app work specifically with DuckDB while maintaining core functionality.
Key changes:
- Enables DuckDB plugin integration and disables progressive arrow loading
- Removes cloud storage providers (Dropbox, Carto) that aren't configured for the preview domain
- Customizes sample data presentation by prioritizing tileset examples and removing incompatible datasets
Reviewed Changes
Copilot reviewed 11 out of 13 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/components/src/modals/modal-tabs.tsx | Adds className prop support for custom tab styling |
| src/components/src/modals/load-data-modal.tsx | Updates default method selection and adds callback for data loading |
| package.json | Adds esbuild-plugin-copy dependency |
| examples/demo-app/src/static/_redirects | Adds Netlify SPA redirect configuration |
| examples/demo-app/src/reducers/index.js | Enables DuckDB plugin and disables progressive loading/release banner |
| examples/demo-app/src/components/load-data-modal/sample-maps-tab.js | Updates styling for active tab states |
| examples/demo-app/src/components/load-data-modal/sample-data-viewer.js | Adds "Add data" helper button |
| examples/demo-app/src/cloud-providers/index.js | Disables Dropbox and Carto cloud providers |
| examples/demo-app/src/actions.js | Reorders sample data and filters out incompatible examples |
| examples/demo-app/package.json | Adds esbuild-plugin-copy dependency |
| examples/demo-app/esbuild.config.mjs | Configures file copying for build process |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOT FOR MASTER BRANCH !!! DON'T MERGE. THIS BRANCH IS USED FOR kepler-preview.foursquare.com
inject DuckDb plugin and DuckDb table
disable not configured cloud storage providers - Dropbox, Carto
disable release banner
disable progressive arrow data loading which doesn't work with DuckDB
show Example data panel by default
move tileset examples to the top, remove trips example
fix for custom domains under SPA page / netlify