Skip to content

[feat] wms layer improvements - #3151

Merged
igorDykhta merged 10 commits into
masterfrom
igr/wms-improvements
Jul 7, 2025
Merged

[feat] wms layer improvements#3151
igorDykhta merged 10 commits into
masterfrom
igr/wms-improvements

Conversation

@igorDykhta

@igorDykhta igorDykhta commented Jul 6, 2025

Copy link
Copy Markdown
Collaborator
  • tests
  • click and request wms data for tooltip

Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
@igorDykhta
igorDykhta marked this pull request as ready for review July 7, 2025 19:25
Copilot AI review requested due to automatic review settings July 7, 2025 19:25

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances WMSLayer by adding click-to-query feature info tooltips and covers it with extensive tests.

  • Introduces new tests for WMSLayer constructor, config updates, hover/render behavior, data formatting, XML parsing, and error handling
  • Implements wmsFeatureInfo action, reducer handler, and layer callback to pin and display feature info on click
  • Extends WMSLayer to fetch, parse, and render feature info, and updates UI components and translations to support WMS tooltips

Reviewed Changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
test/node/layers/wms-layer-test.js Adds comprehensive tests for WMSLayer functionality
src/table/src/dataset-utils.ts Includes queryable flag in WMS dataset metadata
src/reducers/src/vis-state.ts Registers WMS_FEATURE_INFO action
src/reducers/src/vis-state-updaters.ts Implements wmsFeatureInfoUpdater in vis-state updaters
src/localization/src/translations/en.ts Adds placeholder WMS hover translation entry
src/layers/src/wms-layer/wms-layer.ts Enhances WMSLayer with getHoverData, click handler, parsing
src/deckgl-layers/src/wms/wms-layer.ts Exposes pickable prop in Deck WMS composite layer
src/components/src/map/layer-hover-info.tsx Renders WMS feature data in tooltip rows
src/components/src/map-container.tsx Wires up onWMSFeatureInfo callback in MapContainer
src/actions/src/vis-state-actions.ts Defines WMSFeatureInfoAction and wmsFeatureInfo action
src/actions/src/action-types.ts Adds WMS_FEATURE_INFO constant

Comment thread src/layers/src/wms-layer/wms-layer.ts
Comment thread src/reducers/src/vis-state-updaters.ts Outdated
Comment thread src/localization/src/translations/en.ts
Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
@igorDykhta
igorDykhta requested a review from ilyabo July 7, 2025 22:10
@igorDykhta
igorDykhta merged commit 343b554 into master Jul 7, 2025
8 checks passed
@igorDykhta
igorDykhta deleted the igr/wms-improvements branch July 7, 2025 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants