[fix] DuckDB mode: space in column name breaks file import (#3153) - #3156
Merged
Conversation
Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses issue #3153 by ensuring column names with spaces or special characters are properly quoted in DuckDB SQL queries.
- Introduces a
quoteColumnNamehelper to escape double quotes. - Applies identifier quoting in
castDuckDBTypesForKeplerfor all column references.
Comments suppressed due to low confidence (1)
src/duckdb/src/table/duckdb-table-utils.ts:69
- Consider adding unit tests for
quoteColumnNameandcastDuckDBTypesForKeplerto cover edge cases like column names with spaces, quotes, or reserved words.
function quoteColumnName(columnName: string): string {
ilyabo
reviewed
Jul 10, 2025
ilyabo
approved these changes
Jul 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#3153