Skip to content

[fix] vector tile layer - use highlightedFeatureId for hover - #3202

Merged
igorDykhta merged 2 commits into
masterfrom
igr/vector-tile-uuid-impr
Aug 30, 2025
Merged

[fix] vector tile layer - use highlightedFeatureId for hover#3202
igorDykhta merged 2 commits into
masterfrom
igr/vector-tile-uuid-impr

Conversation

@igorDykhta

@igorDykhta igorDykhta commented Aug 30, 2025

Copy link
Copy Markdown
Collaborator

For #3012

  • in vector tile layer rely on built in highlightedFeatureId for hovering
  • add more props for unique id
  • smart outline calculation for features that are in multiple tiles

Before:
Screenshot 2025-08-30 at 6 03 17 PM

After:
Screenshot 2025-08-30 at 11 13 42 PM

Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes vector tile layer hovering by utilizing the built-in highlightedFeatureId mechanism instead of creating a separate hover layer. The implementation automatically detects unique ID properties from features to enable consistent highlighting across adjacent tiles.

Key changes:

  • Removes the separate GeoJsonLayer for hover effects
  • Implements automatic unique ID property detection using predefined candidates
  • Integrates with deck.gl's built-in highlighting system via highlightedFeatureId and uniqueIdProperty

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread src/layers/src/vector-tile/vector-tile-layer.ts
Comment thread src/layers/src/vector-tile/vector-tile-layer.ts
Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
@igorDykhta
igorDykhta merged commit 2b8af82 into master Aug 30, 2025
8 checks passed
@igorDykhta
igorDykhta deleted the igr/vector-tile-uuid-impr branch August 30, 2025 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants