Skip to content

[fix] icon layer - render default icon in case svgIconUrl loading fails #3204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
igorDykhta merged 3 commits into from
Sep 3, 2025
Merged

[fix] icon layer - render default icon in case svgIconUrl loading fails #3204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6dc698e
[fix] icon layer - render default icon in case svgIconUrl loading fails
igorDykhta Aug 31, 2025
4b0126c
nit
igorDykhta Aug 31, 2025
ac63b17
fix test
igorDykhta Aug 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
87 changes: 49 additions & 38 deletions src/layers/src/icon-layer/icon-layer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,10 +209,23 @@ export default class IconLayer extends Layer {

if (Window.fetch && this.svgIconUrl) {
Window.fetch(this.svgIconUrl, fetchConfig)
.then(response => response.json())
.then(response => {
if (!response.ok) {
throw new Error(`Failed to load svg-icons.json: ${response.status}`);
Comment thread
igorDykhta marked this conversation as resolved.
}
return response.json();
})
.then((parsed: {svgIcons?: any[]} = {}) => {
this.setSvgIcons(parsed.svgIcons);
})
.catch(err => {
console.error('Error fetching or parsing svg-icons.json:', err);
// Fallback to empty geometry to allow default icon rendering
this.iconGeometry = {};
});
} else {
// No fetch available; set empty geometry so layer can render default icons
this.iconGeometry = {};
}
}

Expand Down Expand Up @@ -389,42 +402,40 @@ export default class IconLayer extends Layer {
cullFace: GL.FRONT
};

return !this.iconGeometry
? []
: [
new SvgIconLayer({
...defaultLayerProps,
...brushingProps,
...layerProps,
...data,
parameters,
getIconGeometry: id => this.iconGeometry?.[id],

// update triggers
updateTriggers,
extensions
}),

// hover layer
...(hoveredObject
? [
// @ts-expect-error SvgIconLayerProps needs getIcon Field
new SvgIconLayer({
...this.getDefaultHoverLayerProps(),
...layerProps,
visible: defaultLayerProps.visible,
data: [hoveredObject],
parameters,
getPosition: data.getPosition,
getRadius: data.getRadius,
getFillColor: this.config.highlightColor,
getIconGeometry: id => this.iconGeometry?.[id]
})
]
: []),

// text label layer
...labelLayers
];
return [
new SvgIconLayer({
...defaultLayerProps,
...brushingProps,
...layerProps,
...data,
parameters,
getIconGeometry: id => this.iconGeometry?.[id],

// update triggers
updateTriggers,
extensions
}),

// hover layer
...(hoveredObject
? [
// @ts-expect-error SvgIconLayerProps needs getIcon Field
new SvgIconLayer({
...this.getDefaultHoverLayerProps(),
...layerProps,
visible: defaultLayerProps.visible,
data: [hoveredObject],
parameters,
getPosition: data.getPosition,
getRadius: data.getRadius,
getFillColor: this.config.highlightColor,
getIconGeometry: id => this.iconGeometry?.[id]
})
]
: []),

// text label layer
...labelLayers
];
}
}
4 changes: 2 additions & 2 deletions test/browser/layer-tests/icon-layer-specs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,8 +270,8 @@ test('#IconLayer -> renderLayer', t => {
t.equal(layer.type, 'icon', 'should create 1 icon layer');
t.equal(
deckLayers.length,
0,
'Should create 0 deck.gl layer when icon geometry is not provided'
3,
'Should create 3 deck.gl layer when default icon geometry is not provided or missing'
);
}
},
Expand Down