Update kepler-jupyter to use kepler.gl v3.2.0 - #3219
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Upgrade kepler.gl Jupyter bindings to kepler.gl v3.2.0 and migrate the build to webpack 5, while ensuring the map resizes correctly after mounting.
- Migrate webpack config to v5 (library/type format, fallbacks, loaders) and add necessary polyfills/loaders
- Bump kepler.gl and loaders.gl packages to 3.2.0/4.3.x respectively
- Defer data/config injection until after mount and trigger initial resize to fix map sizing in Jupyter
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| bindings/kepler.gl-jupyter/js/webpack/config.js | Webpack 5 migration across bundles, new loaders, env/provide plugins, AMD library output changes |
| bindings/kepler.gl-jupyter/js/webpack/build-html.js | Webpack 5 output format, resolve fallbacks (fs/process), UMD library config |
| bindings/kepler.gl-jupyter/js/package.json | Upgrade webpack/dev tooling and kepler.gl/loaders.gl versions; add process polyfill dependency |
| bindings/kepler.gl-jupyter/js/lib/keplergl/main.js | Render callback to load data/config after mount |
| bindings/kepler.gl-jupyter/js/lib/keplergl/components/root.js | Support onMounted callback via useEffect |
| bindings/kepler.gl-jupyter/js/lib/keplergl/components/app.js | Trigger an initial resize on mount |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
- update webpack to v5 and migrate configs Signed-off-by: karosc <ckaros@outlook.com>
Signed-off-by: karosc <ckaros@outlook.com>
Signed-off-by: karosc <ckaros@outlook.com>
karosc
force-pushed
the
update-jupyter-plugin
branch
from
October 12, 2025 20:50
e493203 to
5016513
Compare
igorDykhta
self-requested a review
October 12, 2025 21:22
Contributor
Author
|
thanks @lixun910, who merges this? Do we just need to wait untit @igorDykhta has time? I don't want to rush things, I only want to makes sure this doesn't get forgotten. |
Collaborator
|
Thanks @karosc. Sorry, I’m not working on the Jupyter part, so I expected Xun to handle this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not a pro js developer, but I use the keplergl python library for rendering GIS maps and wanted to fix #3045. I also tried updating the build process to accommodate
@kepler.gl v3.2.0, which largely involved updating webpack to v5. I'm fine with closing this out if ya'll are not interested or think I took the wrong approach in any way.