fix: fix image export for non-webpack bundlers - #3266
Merged
Merged
Conversation
igorDykhta
commented
Dec 23, 2025
Collaborator
- fix image export for non-webpack bundlers
- fix image export for the latest electron versions
Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes image export functionality for non-webpack bundlers (e.g., Vite) and modern Electron versions by switching from URL-encoded SVG data URIs to base64-encoded data URIs and adding auto-detection of the build tool being used.
Key Changes:
- Replaced
svgToMiniDataURIwith base64 encoding to avoid URL encoding issues in Electron's security restrictions - Added automatic webpack detection via
isWebpackBuild()function to conditionally apply XHTML escaping fixes - Updated default export image configuration to use auto-detected build tool settings
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
src/utils/src/dom-to-image.ts |
Switched from svgToMiniDataURI to base64 encoding for SVG data URIs, using Buffer in Node.js and btoa in browsers |
src/utils/src/application-config.ts |
Added isWebpackBuild() detection function and new escapeXhtmlForWebpack configuration option with auto-detection |
src/reducers/src/ui-state-updaters.ts |
Updated DEFAULT_EXPORT_IMAGE to read escapeXhtmlForWebpack from application config instead of hardcoding to true |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 5 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ilyabo
approved these changes
Dec 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.