Skip to content

fix: name new point layer using label if provided (follow-up) #3297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lixun910 merged 6 commits into from
Feb 5, 2026
Merged

fix: name new point layer using label if provided (follow-up) #3297

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c7d9d51
Update kepler-table.ts
lixun910 Feb 5, 2026
59d9679
address comments
lixun910 Feb 5, 2026
fcca3af
update fix
lixun910 Feb 5, 2026
b9f22a5
Update point-layer.ts
lixun910 Feb 5, 2026
57f36c8
Update layer-utils-test.js
lixun910 Feb 5, 2026
a697fe2
Update src/layers/src/point-layer/point-layer.ts
lixun910 Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/layers/src/point-layer/point-layer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,9 +347,10 @@ export default class PointLayer extends Layer {
columns?: PointLayerColumnsConfig;
} = {
label:
Comment thread
lixun910 marked this conversation as resolved.
pair.defaultName ||
(typeof label === 'string' && label.replace(/\.[^/.]+$/, '')) ||
'Point'
// Skip the generic 'point' fallback from findPointFieldPairs and use the dataset label instead
pair.defaultName && pair.defaultName !== 'point'
? pair.defaultName
: (typeof label === 'string' && label.replace(/\.[^/.]+$/, '')) || 'Point'
};

// default layer color for begintrip and dropoff point
Expand Down
2 changes: 1 addition & 1 deletion test/node/utils/layer-utils-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ test('layerUtils -> findDefaultLayer.1', t => {
}
}),
new PointLayer({
label: 'point',
label: 'Point',
dataId,
columns: {
lat: {
Expand Down