rollback change, and truncate tooltip - #3300
Merged
igorDykhta merged 3 commits intoFeb 6, 2026
Merged
Conversation
Signed-off-by: bdjulbic <bdjulbic@foursquare.com>
bdjulbic
force-pushed
the
fix/truncate-tooltip-value-pr
branch
from
February 6, 2026 14:03
1a8f8bd to
81a1520
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request rolls back the WKT (Well-Known Text) heuristic detection feature and adds tooltip value truncation to improve UI readability.
Changes:
- Removed
isWktfunction and related test cases that performed heuristic WKT geometry detection - Added truncation for long tooltip values (>60 chars truncated to 30 chars) using lodash/truncate
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/node/utils/dataset-utils-test.js | Removed isWkt test cases and updated import statement |
| src/common-utils/src/data-type.ts | Removed isWkt function and WKT detection logic from field type analysis |
| src/components/src/map/layer-hover-info.tsx | Added tooltip truncation with configurable thresholds for better UX |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bdjulbic
commented
Feb 6, 2026
| const H3_ANALYZER_TYPE = 'H3'; | ||
|
|
||
| // Returns true if the value is likely a WKT geometry string (heuristic check). | ||
| const WKT_PREFIX_RE = |
Contributor
Author
There was a problem hiding this comment.
Rollbacking this change from previous PR
it wasn't covering all usecases
instead option for truncating very long tooltip
bdjulbic
commented
Feb 6, 2026
| t.end(); | ||
| }); | ||
|
|
||
| test('datasetUtils.isWkt', t => { |
Contributor
Author
There was a problem hiding this comment.
Rollbacking this change from previous PR
it wasn't covering all usecases
instead option for truncating very long tooltip
Signed-off-by: bdjulbic <bdjulbic@foursquare.com>
bdjulbic
force-pushed
the
fix/truncate-tooltip-value-pr
branch
from
February 6, 2026 14:31
6919cdc to
0d3a797
Compare
Signed-off-by: bdjulbic <bdjulbic@foursquare.com>
bdjulbic
force-pushed
the
fix/truncate-tooltip-value-pr
branch
from
February 6, 2026 14:32
196c444 to
368e356
Compare
igorDykhta
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rollback of #3298
The previous fix for hiding geometry fields in tooltips wasn't covering all use cases.
Problem: Geometry fields loaded as strings via CSV (displayed as vector tilesets) show excessively long WKT values in map tooltips.
Solution: Apply truncation to tooltip values exceeding 60 characters, shortening them to 30 characters with ellipsis. This handles all long string values uniformly without needing to detect specific field types.
