fix: geocoder coordinate search results not showing (#2245) - #3322
Merged
igorDykhta merged 1 commit intoApr 4, 2026
Merged
Conversation
When entering coordinates in the geocoder search box, the results dropdown might not appear or could be overwritten by a pending geocoder API call. Fix by: 1. Clearing any pending geocoder debounce timeout when valid coordinates are detected, preventing stale API results from overwriting the coordinate result. 2. Explicitly setting showResults to true to ensure the dropdown is visible. Signed-off-by: pierreeurope <pierre.europe@pm.me>
igorDykhta
approved these changes
Apr 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2245
When entering coordinates directly in the geocoder search box (e.g.,
3.5260, 98.6736), the marker might not appear because:Pending geocoder API call could overwrite results: If the user types a partial string that triggers the debounced mapbox geocoder, then modifies it to valid coordinates, the pending API call could overwrite the coordinate results when it resolves.
Results dropdown might not be visible: The
showResultsstate was not explicitly set totruein the coordinate path, relying on the focus handler which might not have fired.Changes
In the coordinate detection branch of the
onChangehandler ingeocoder.tsx:showResultstotrueto ensure the dropdown is visibleTesting
3.5260, 98.6736