Skip to content

fix(line-chart): adjust Y-axis domain to filtered time range #3333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pierreeurope wants to merge 1 commit into from
Closed

fix(line-chart): adjust Y-axis domain to filtered time range #3333

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 21 additions & 3 deletions src/components/src/common/line-chart.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ interface LineChartProps {
lineChart?: LineChart;
margin: {top?: number; bottom?: number; left?: number; right?: number};
onMouseMove: (datapoint: LineSeriesPoint | null, data?: RVNearestXData<LineSeriesPoint>) => void;
value?: number[];
width: number;
timezone?: string | null;
timeFormat?: string;
Expand All @@ -101,6 +102,7 @@ function LineChartFactory() {
lineChart,
margin,
onMouseMove,
value,
width,
timezone,
timeFormat
Expand All @@ -109,12 +111,28 @@ function LineChartFactory() {
// @ts-expect-error seems lineChart.series has ambiguous types. Requires refactoring.
const series: {lines: any[]; markers: any[]} = lineChart?.series;

// Compute y-domain from only the visible (filtered) data points
const filteredYDomain = useMemo(() => {
if (!series?.lines || !value || value.length < 2) return yDomain;
let min: number | undefined;
let max: number | undefined;
for (const line of series.lines) {
for (const point of line) {
if (point.x >= value[0] && point.x <= value[1] && point.y != null) {
if (min === undefined || point.y < min) min = point.y;
if (max === undefined || point.y > max) max = point.y;
}
}
}
return min !== undefined && max !== undefined ? [min, max] : yDomain;
}, [series, value, yDomain]);

const paddedYDomain = useMemo(
() =>
yDomain && yDomain[0] && yDomain[1]
? [yDomain[0], yDomain[1] + (yDomain[1] - yDomain[0]) * 0.2]
filteredYDomain && filteredYDomain[0] != null && filteredYDomain[1] != null
? [filteredYDomain[0], filteredYDomain[1] + (filteredYDomain[1] - filteredYDomain[0]) * 0.2]
: [],
[yDomain]
[filteredYDomain]
);
const brushData = useMemo(() => {
return xDomain && paddedYDomain
Expand Down