fix: create trip layer from duckdb table - #3344
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request enables the creation of trip layers from DuckDB tables by adding support for XYZM (4D) coordinate handling and table column mode detection. The changes address the issue where trip data with timestamps embedded in GeoJSON coordinates was not being properly imported and used to create trip layers.
Changes:
- Added detection and custom parsing for GeoJSON with XYZM (4D) coordinates to preserve timestamp data
- Extended trip layer detection to support geoarrow field types and table column mode
- Modified ID field detection to be more flexible and ensured consistent ID handling via string conversion
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| src/layers/src/trip-layer/trip-layer.ts | Added support for geoarrow field types and table column mode detection for trip layers |
| src/layers/src/geojson-layer/geojson-utils.ts | Modified ID field detection regex and converted IDs to strings for consistent grouping behavior |
| src/duckdb/src/table/duckdb-table.ts | Implemented XYZM coordinate detection and custom import path to preserve 4D coordinates including timestamps |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
igorDykhta
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.