Skip to content

Fixed: #1722 Run out of memory#1724

Open
Anselmoo wants to merge 1 commit into
keras-team:masterfrom
Anselmoo:out-of-memory
Open

Fixed: #1722 Run out of memory#1724
Anselmoo wants to merge 1 commit into
keras-team:masterfrom
Anselmoo:out-of-memory

Conversation

@Anselmoo

Copy link
Copy Markdown
Contributor

Update utils.py and test by using break instead of raise

Which issue(s) does this Pull Request fix?

resolves #1722

Details of the Pull Request

According to discussion #1721, theraise will be replaced by break for running out of memory in the case of batch_size==1
.

Update utils.py and test by using `break` instead of `raise`
@codecov

codecov Bot commented May 14, 2022

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (c51da2d) to head (f477215).
⚠️ Report is 99 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #1724   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           51        51           
  Lines         3411      3413    +2     
=========================================
+ Hits          3411      3413    +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@haifeng-jin haifeng-jin left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

If history is None, it should trigger this error. To your test, does it trigger it?
We can first add a if to check its None, return an empty dict.

Check for empty dict in Oracle.update_trial to return invalid status.

I can make the change if you prefer?

@Anselmoo

Copy link
Copy Markdown
Contributor Author

Thanks for the fix!

If history is None, it should trigger this error. To your test, does it trigger it? We can first add a if to check its None, return an empty dict.

Check for empty dict in Oracle.update_trial to return invalid status.

I can make the change if you prefer?

Will be the changes small, then I would prefer if you would do it because I have to first get into the code. Otherwise, I will take later a look.

@haifeng-jin

Copy link
Copy Markdown
Collaborator

@Anselmoo I will make the fix then, it may take some time. Thanks.

@haifeng-jin

Copy link
Copy Markdown
Collaborator

This is blocked by:
keras-team/keras-tuner#704

@haifeng-jin
haifeng-jin requested a review from fchollet as a code owner January 20, 2023 21:44
Comment thread autokeras/utils/utils.py
except tf.errors.ResourceExhaustedError:
if batch_size == 1:
raise e
print(

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if using print a right approach here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

resnet_v2-models can cause out of memory error

3 participants