Skip to content

Register Magistral Presets to Hub#2845

Draft
laxmareddyp wants to merge 1 commit into
keras-team:masterfrom
laxmareddyp:register_magistral_presets
Draft

Register Magistral Presets to Hub#2845
laxmareddyp wants to merge 1 commit into
keras-team:masterfrom
laxmareddyp:register_magistral_presets

Conversation

@laxmareddyp

@laxmareddyp laxmareddyp commented Jul 18, 2026

Copy link
Copy Markdown
Collaborator

Description of the change

Reference

Colab Notebook

Checklist

  • I have added all the necessary unit tests for my change.
  • I have verified that my change does not break existing code and works with all backends (TensorFlow, JAX, and PyTorch).
  • My PR is based on the latest changes of the main branch (if unsure, rebase the code).
  • I have followed the Keras Hub Model contribution guidelines in making these changes.
  • I have followed the Keras Hub API design guidelines in making these changes.
  • I have signed the Contributor License Agreement.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds two new model presets to the Mistral model configuration. The review feedback correctly identifies a naming inconsistency where 'magistral' is used instead of 'mistral', which appears to be a typo or AI hallucination. The reviewer has provided a clear code suggestion to rename these presets to 'mistral_small' to align with repository standards.

Comment thread keras_hub/src/models/mistral/mistral_presets.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant