Skip to content

Fix/issue 1032 nan metrics crash #1050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Quant-Quasar wants to merge 3 commits into
base: master
Choose a base branch
from
+9 −5
Open

Fix/issue 1032 nan metrics crash #1050

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
91c892f
fix: prevent RuntimeWarning when metric history is all-NaN (fixes #1032)
Quant-Quasar Dec 19, 2025
123184a
fix: prevent RuntimeWarning when metric history is all-NaN
Quant-Quasar Dec 20, 2025
9702caf
perf: use native NumPy array for metric history processing
Quant-Quasar Dec 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions keras_tuner/engine/metrics_tracking.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,12 +104,15 @@ def update(self, value, step):
self._observations[step] = MetricObservation(value, step=step)

def get_best_value(self):
values = [obs.mean() for obs in self._observations.values()]
if not values:
if not self._observations:
return None
return (
np.nanmin(values) if self.direction == "min" else np.nanmax(values)
)
values = [obs.mean() for obs in self._observations.values()]

# If true, return NaN immediately to avoid numpy RuntimeWarning
if all(np.isnan(v) for v in values):
return np.nan

return np.nanmin(values) if self.direction == "min" else np.nanmax(values)
Comment thread
Quant-Quasar marked this conversation as resolved.
Outdated

def get_best_step(self):
best_value = self.get_best_value()
Expand Down