Make bucket force_destroy configurable#211
Open
MarcosAsh wants to merge 1 commit intokeras-team:mainfrom
Open
Conversation
MarcosAsh
requested review from
JyotinderSingh,
divyashreepathihalli and
jeffcarp
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a force_destroy configuration for GCS buckets, allowing users to control whether buckets are automatically emptied during teardown. It adds a --force-destroy/--no-force-destroy CLI option to the up command, implements state persistence for this setting, and ensures it is correctly propagated to the underlying Pulumi infrastructure. The implementation follows the repository's precedence rules (CLI flag > existing state > default) and includes comprehensive unit tests. I have no feedback to provide as there were no review comments to evaluate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
--force-destroy/--no-force-destroy(env:KINETIC_FORCE_DESTROY) tokinetic up. The setting is persisted viapulumi.exportand read back byload_state, sopool add/removepreserve it instead of silently reverting. Default staysforce_destroy=True.#23 bundles 5 separate config requests. This PR addresses the first (force_destroy on pulumi resources). The other 4 (multi-GPU node pools, pulumi state backend, stateful CLI configs, CLI config updates) are out of scope for this PR.