Fix GlobalAveragePooling1D with an empty batch and a mask#906
Open
theomeb wants to merge 1 commit into
Open
Conversation
Casting the mask with tf.cast(mask, inputs[0].dtype) indexes the batch dimension of inputs, triggering a StridedSlice that fails when the batch is empty (e.g. when MirroredStrategy hands an empty shard to a replica). Cast against inputs.dtype instead, which reads the dtype without indexing the data. Adds a regression test for an empty batch passed together with a mask. See tensorflow/tensorflow#67023
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request fixes an issue in GlobalAveragePooling1D where casting the mask using inputs[0].dtype would fail on empty batches. The code is updated to use inputs.dtype directly instead. Additionally, a unit test has been added to verify that the layer correctly handles empty batches with a mask. There are no review comments, so no further feedback is provided.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the crash when GlobalAveragePooling1D is called on an empty batch with a mask (StridedSlice index 0 of dimension 0 out of bounds), e.g. under MirroredStrategy when a replica gets an empty shard.
The cast
tf.cast(mask, inputs[0].dtype)indexes the batch dim; changing it toinputs.dtypeavoids touching the data. Includes a regression test in global_average_pooling_test.py (passes in graph and eager modes).Upstream issue: tensorflow/tensorflow#67023