Add project-scoped vault payment tools - #181
Open
rgarcia wants to merge 2 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a01031b. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
manage_vaultsusing the existing action-based tool registration, project selection, Zod schemas, SDK calls, and JSON/error helpers. Cover vault selection/creation/deletion, Link and AgentCard wallet/card lifecycle, advertised authorization operations, funding-method expansion, and item events.vaultsattachments tomanage_browserscreation, with exactly one ID/name per reference and the API's 20-vault bound.SDK preview
Use the compiled SDK from
kernel/kernel-node-sdk-staging, preview branchstlc/preview/pr-3698, pinned at768cea122220150aacc33074ea00a1c0afaf879e, not the released SDK. The generated package still reports version0.98.0; the archive's commit and digest identify this preview.The source-only preview requires private repository access and does not install directly with the project's Bun version. Vendor its unmodified build output so public CI and contributors can install without those credentials.
vendor/README.mdrecords provenance, SHA-256, and rebuild commands. Two builds produced byte-identical archives. Only the intended SDK entries inbun.lockchange; other generated project files are untouched.Validation
Run with Bun 1.3.3:
bun install --frozen-lockfile— passes, including a fresh temporary checkout with an empty dependency cache.bunx tsc --noEmit --incremental false— passes, including the fresh checkout.bun test— 330 passing tests; also passes in the fresh checkout.bun test src/lib/mcp/tools/vaults.test.ts src/lib/mcp/tools/browser-vaults.test.ts src/lib/mcp/register.test.ts src/lib/mcp/responses.test.ts— 54 passing focused tests, including real preview-SDK requests with mocked HTTP responses.bun run check:managed-auth-appand Prettier checks on every changed TS/JSON/Markdown file — pass.git diff main...HEAD --checkpasses.Existing checks outside this change remain broken:
bun run format:checkreports only the pre-existingAGENTS.mdformatting issue;bun run lintinvokesnext lint, which Next.js 16 removed. Neither unrelated issue is changed here.Limitations
Requires the corresponding vault-enabled API. The preview has no writable permitted-domains field and no per-item AgentCard test flag; descriptions explicitly preserve those limitations. Event payloads and unstructured authorization reasons are deliberately omitted from MCP output. Replace the vendored preview once a released SDK supplies the same API.
No live provider calls, payments, manual deployments, or changes to either SDK repository or the API repository were performed. The repository's existing Vercel integration automatically generated a branch preview.