Moves configs to repo variables#550
Merged
Merged
Conversation
fiskeben
had a problem deploying
to
balena-draft-fleet
GitHub Actions
Failure
fiskeben
had a problem deploying
to
balena-draft-fleet
GitHub Actions
Failure
fiskeben
had a problem deploying
to
balena-draft-fleet
GitHub Actions
Failure
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Balena deployment GitHub Actions workflow to remove hard-coded personal configuration and instead read the Balena auth token and target fleet from GitHub repository secrets/variables, aligning naming with the Balena workflow setup described in the PR.
Changes:
- Removes the hard-coded Balena fleet/app identifier from the workflow-level
env. - Updates the deployment step to use
secrets.BALENA_TOKENfor authentication. - Updates the deployment step to use
vars.FLEETfor the target fleet, and normalizes the job name text.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Owner
|
Thanks, @fiskeben! This makes sense. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes hard coded personal variables in the GitHub workflow and reads them from the repository's secrets and variables instead.
Note that the names are changed to match the name in the Balena workflow.