Skip to content

Deleting workspace no longer delete files on filesystem #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
BraveMole wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Deleting workspace no longer delete files on filesystem #2

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9d1e541
No longer delete the files on the file system
BraveMole Mar 23, 2026
4bc5559
Fix message
BraveMole Mar 23, 2026
99716fb
Separate both prs
BraveMole Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions lua/fzf-lua/pickers/workspaces.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,9 @@ local function delete_workspace(ws_name)
log.error("unexpectedly could not get workspace " .. ws_name)
return
end
local result = os.execute("rm -rf " .. ws)
if not result then
log.error("failed to delete workspace " .. ws_name)
else
log.info("deleted workspace " .. ws_name)
if not dirman.delete_workspace(ws_name) then
log.error("cannot delete workspace, are you sure it is a dynamically created one ?")
return
end
if dirman.get_current_workspace()[2] == ws then
dirman.set_workspace("default")
Expand Down Expand Up @@ -86,7 +84,7 @@ local M = {
[opts.pickers.keymaps.delete] = {
function(ws_name)
local confirm = vim.fn.confirm(
"delete workspace " .. ws_name[1] .. "? (this will delete all files in the workspace)",
"delete workspace " .. ws_name[1] .. "?",
"&Yes\n&No",
2
)
Expand Down