Fix typos and ambiguities#2
Open
minnerbe wants to merge 4 commits intokevinyamauchi:add-tables-pointsfrom
Open
Fix typos and ambiguities#2minnerbe wants to merge 4 commits intokevinyamauchi:add-tables-pointsfrom
minnerbe wants to merge 4 commits intokevinyamauchi:add-tables-pointsfrom
Conversation
* Slightly reformulate chunking of obs and var to eliminate ambiguities * Chunking for obs and var is now consistent with osbm and varm * Data in tables SHOULD now be consistently chunked the same as the corresponding dimension of X. This now includes ALL datatypes that can be used as columns. * Data and indices of sparse matrices SHOULD be chunked in the same way.
Automated Review URLs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Kevin, thanks for putting together this addition to the OME-NGFF spec!
I've been reading the table spec very carefully lately and came across some minor typos and (perceived) ambiguities. Therefore, I suggest a few changes that hopefully contribute to the spec being more precise and complete:
vargroup, so I put them one level higher.obsandvardataframes seemed ambiguous to me. I tried to make it as clear as possible and consistent withobsmandvarm.codes,maskandvaluesarray should be chunked the same way as the corresponding dimension ofX;dataandindicesarrays of sparse matrices should be chunked in the same way.Furthermore, I am confused by the absence of nullable integers and categoricals in the
obsgroup. In my understanding,obsandvarshould be qualitatively the same, but associated with different dimensions ofX, is this correct?If this absence is unintentional, I suggest to add nullable integers and categoricals also to
obsand I'd be happy to do so.