Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
POC. Not entirely sure the
/RELEASESbit is functional (e.g. does Squirrel.Windows send auth? I think I remember it doesn't, but not 100% sure). Also not sure I even want to support Squirrel at all, since it seems to be largely unmaintained and likely to be replaced at some point by Electron (e.g. with something similar to Tauri's update system). If Squirrel.Windows doesn't send auth, we'd need to build our ownRELEASESfile and use signed auth.Right now, most users either use electron-builder with static artifact uploads, or Electron's support for static files. Not sure if adding an Electron engine brings anything new to the table, but worth exploring.
Related to #493.