Skip to content

Update ontology file to include definitions for rml:FilePath - #174

Merged
s-minoo merged 2 commits into
mainfrom
fix/issue-170
Aug 19, 2026
Merged

s-minoo merged 2 commits into
mainfrom
fix/issue-170

Conversation

@s-minoo

@s-minoo s-minoo commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Fixes #170 by defining rml:FilePath in the ontology file https://github.com/kg-construct/rml-io/blob/main/ontology/rml-io.owl

@s-minoo
s-minoo merged commit c0c5902 into main Aug 19, 2026
1 check passed
@s-minoo
s-minoo deleted the fix/issue-170 branch August 19, 2026 11:40

@hartig hartig left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@s-minoo I see that you have merged this PR already, but it seems to me that you have made two mistakes. See my comments.

<http://purl.org/dc/terms/created> "2023-03-14" ;
<http://purl.org/dc/terms/description> "RML-IO enables the description of input data sources and target output data serialization "@en ;
<http://purl.org/dc/terms/license> <http://purl.org/NET/rdflicense/cc-by4.0> ;
<http://purl.org/dc/terms/modified> "2025-01-18" ;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this date be updated as well??

Comment on lines +146 to +150
rdfs:domain [ rdf:type owl:Class ;
owl:unionOf ( <http://w3id.org/rml/FilePath>
<http://w3id.org/rml/RelativePath>
)
] ;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change seems to be in contradiction to the RML-IO spec: In Section 3.3 of that spec (you need to scroll a bit further down), there is a table which says that the (only) domain of rml:root is rml:FilePath, not the union of rml:FilePath and rml:RelativePath.

Also, rml:RelativePath is not actually mentioned in the RML-IO spec.

Comment on lines +229 to +233
rdfs:domain [ rdf:type owl:Class ;
owl:unionOf ( <http://w3id.org/rml/FilePath>
<http://w3id.org/rml/LogicalSource>
)
] ;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same type of contradiction for this one: The table a bit further down in Section 3.3 of the RML-IO spec says that the (only) domain of rml:path is rml:FilePath, not the union of rml:FilePath and rml:LogicalSource. And, I don't find an example in the RML-IO spec (and also not in the RML-Core spec) where an rml:LogicalSource has an rml:path property.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Where is rml:FilePath defined?

2 participants