test: make org.jbpm.kie.services.test.ProcessServiceWithEntitiesTest deterministic#2495
Open
Jack-LuoHongyi wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
jbpm-services/jbpm-kie-servicesorg.jbpm.kie.services.test.ProcessServiceWithEntitiesTest#testStartProcessAndGetVariablesRoot Cause
NonDex randomizes iteration order of unordered collections.
DeploymentDescriptorImpl#toXml()depends on the iteration order of internalHashMap/HashSet, producing deployment descriptor XML with non-deterministic element ordering. Under some seeds, the generated XML violatesdeployment-descriptor.xsdsequence constraints, causing the test setup to fail intermittently.Fix
Avoid
DeploymentDescriptorImpl#toXml()in the test setup. Build the deployment descriptor XML directly in a fixed order that matches the schema, while preserving the same remotable classes and marshalling strategy. This keeps the kjar semantically identical but makes setup deterministic.Validation
QueryServiceImplTest) remains stableRisk
Low. Changes are limited to test setup and only enforce deterministic XML ordering without relaxing assertions or affecting production code.