Skip to content

[codex] fix(desktop): keep feedback rail visible after loading a site - #10

Draft
zacklavin11 wants to merge 1 commit into
kieranklaassen:mainfrom
zacklavin11:codex/fix-desktop-feedback-rail-layout
Draft

[codex] fix(desktop): keep feedback rail visible after loading a site#10
zacklavin11 wants to merge 1 commit into
kieranklaassen:mainfrom
zacklavin11:codex/fix-desktop-feedback-rail-layout

Conversation

@zacklavin11

Copy link
Copy Markdown

Summary

  • Pin the desktop feedback rail to the second grid column.
  • Keeps the recorder controls visible after a website loads and the empty-state panel is hidden.

Root cause

The desktop workspace is a two-column CSS grid. After a site loads, the renderer hides #empty-state, leaving .feedback-rail as the only grid item. Without an explicit grid column, auto-placement moves the rail into column 1, where it sits underneath the Electron WebContentsView; column 2 appears blank.

Validation

  • npm run typecheck from desktop/
  • npm test from desktop/
  • npm run build from desktop/

Manual repro

  1. Open Riffrec Desktop.
  2. Load any website in the address bar.
  3. Observe that the right feedback sidebar is blank in the preview build.
  4. With this change, the feedback rail stays in the right column.

@mkrueger12

Copy link
Copy Markdown

Also hit this bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants