Correcting lamé parameters for plane stress model#1209
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates plane_stress to return plane-stress Lamé parameters and expands the docstring to a full NumPyDoc-style description.
Changes:
- Changes
plane_stress(E, nu)to return(lambda, mu)for plane stress using standard formulas. - Replaces the one-line docstring with a detailed Parameters/Returns docstring.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+47
to
+48
| return (E * nu / (1. - nu**2), | ||
| E / (2. * (1. + nu))) |
Comment on lines
+30
to
+31
| """Map Young's modulus and Poisson ratio to plane stress lame parameters. | ||
|
|
Comment on lines
+39
to
+44
| Returns | ||
| ------- | ||
| float | ||
| The first Lamé parameter for plane stress scenario (lambda) | ||
| float | ||
| The second Lamé parameter for plane stress scenario (mu) |
Owner
|
Thanks a lot, I wonder what kind of brainrot lead to this. I don’t remember ever using this function. I’ll just once again verify this formula from some source before merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The former calculation of the lamé parameters lambda and mu is to the best of my understanding wrong. The updated fromulae correspond to the derivation of the lamé parameters derived from the generalized Hooks Law for sigma_zz = 0.