Skip to content

fix(pty): resume child on any WUNTRACED stop signal to prevent hang #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kipz merged 1 commit into from
Jun 17, 2026
Merged

fix(pty): resume child on any WUNTRACED stop signal to prevent hang #53

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions crates/nono-cli/src/exec_strategy.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1714,7 +1714,10 @@ fn wait_for_child_with_pty(
continue;
}
Ok(WaitStatus::Stopped(_, sig)) => {
debug!("Child stopped by signal {}, keeping supervisor alive", sig);
// WUNTRACED surfaces stops from any signal (e.g. SIGTTOU/SIGTTIN).
// Resume the child so the session doesn't hang stopped forever.
debug!("Child stopped by signal {}, resuming", sig);
let _ = signal::kill(child, Signal::SIGCONT);
continue;
}
Ok(WaitStatus::Continued(_)) => {
Expand Down Expand Up @@ -2240,7 +2243,10 @@ fn run_supervisor_loop(
continue;
}
Ok(WaitStatus::Stopped(_, sig)) => {
debug!("Child stopped by signal {}, keeping supervisor alive", sig);
// WUNTRACED surfaces stops from any signal (e.g. SIGTTOU/SIGTTIN).
// Resume the child so the session doesn't hang stopped forever.
debug!("Child stopped by signal {}, resuming", sig);
let _ = signal::kill(child, Signal::SIGCONT);
continue;
}
Ok(WaitStatus::Continued(_)) => {
Expand Down Expand Up @@ -2538,7 +2544,10 @@ fn run_supervisor_loop(
continue;
}
Ok(WaitStatus::Stopped(_, sig)) => {
debug!("Child stopped by signal {}, keeping supervisor alive", sig);
// WUNTRACED surfaces stops from any signal (e.g. SIGTTOU/SIGTTIN).
// Resume the child so the session doesn't hang stopped forever.
debug!("Child stopped by signal {}, resuming", sig);
let _ = signal::kill(child, Signal::SIGCONT);
continue;
}
Ok(WaitStatus::Continued(_)) => {
Expand Down
Loading