Skip to content

fix(pty): don't stop relay on bare POLLHUP/POLLERR without POLLIN #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kipz merged 1 commit into from
Jun 24, 2026
Merged

fix(pty): don't stop relay on bare POLLHUP/POLLERR without POLLIN #54

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions crates/nono-cli/src/exec_strategy.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1958,9 +1958,13 @@ fn handle_pty_poll_events(
resize_revents: libc::c_short,
loop_name: &str,
) -> bool {
if master_revents & (libc::POLLIN | libc::POLLHUP | libc::POLLERR | libc::POLLNVAL) != 0
&& !pty.proxy_master_to_client()
{
// Only relay data — and stop the loop on EOF — when POLLIN is set.
// Bare POLLHUP/POLLERR/POLLNVAL without POLLIN can fire transiently
// during interactive TUI startup (e.g. Node.js reinitialising its TTY)
// and would otherwise cause read() to return EIO, which proxy_master_to_client
// maps to Closed, tearing down the relay while the child is still alive.
// Let waitpid signal child exit instead of relying on PTY master HUP.
if master_revents & libc::POLLIN != 0 && !pty.proxy_master_to_client() {
debug!("Stopping {loop_name} after PTY master relay failure");
return false;
}
Expand Down
Loading