Refactor Loop class to use a LoopTools singleton for tool management for Octane compatibility#28
Merged
Merged
Conversation
fsmonter
force-pushed
the
fix/octane-registrations
branch
from
June 12, 2025 17:15
4eaf290 to
0adcaa1
Compare
fsmonter
force-pushed
the
fix/octane-registrations
branch
from
June 12, 2025 17:18
0adcaa1 to
0be3ff2
Compare
fsmonter
marked this pull request as ready for review
June 12, 2025 17:26
luisdalmolin
approved these changes
Jun 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #26
There is an Octane compatibility issue where registered tools don't persist between request cycles due to
scopedinstance recreation of theLoopclass.The proposed fix is storing the tools in a singleton
LoopTools. Another option is making theLoopclass asingletonbut keep in mind the instance would be shared between users in Octane.Current Behavior
The Issue
boot()which only run once when worker startsCurrent Application Workaround