Drop a navigation guard that never fired - #809
Open
pleek91 wants to merge 1 commit into
Open
Conversation
pleek91
force-pushed
the
drop-dead-navigation-guard
branch
from
August 3, 2026 05:37
b38a82c to
d212897
Compare
pleek91
force-pushed
the
drop-dead-navigation-guard
branch
from
August 3, 2026 05:46
d212897 to
015c59b
Compare
pleek91
force-pushed
the
drop-dead-navigation-guard
branch
from
August 3, 2026 05:49
015c59b to
3ef6f14
Compare
pleek91
force-pushed
the
drop-dead-navigation-guard
branch
from
August 3, 2026 05:51
3ef6f14 to
dc79771
Compare
pleek91
force-pushed
the
drop-dead-navigation-guard
branch
from
August 3, 2026 05:58
dc79771 to
ca99000
Compare
This was referenced Aug 3, 2026
stackoverfloweth
approved these changes
Aug 6, 2026
It compared a copy of a parameter against the parameter it was copied from, so the condition was never true. Its job — keeping a superseded navigation from acting on its own props — is done by the ABANDONED response instead. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
stackoverfloweth
force-pushed
the
drop-dead-navigation-guard
branch
from
August 6, 2026 14:18
ca99000 to
36ac6d5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Stacked on #807. No behaviour change — the code being removed never ran.
setPropsAndUpdateRouteheld a guard meant to stop a superseded navigation from acting on props that arrived late:navigationIdis a parameter and is never reassigned, so the comparison was always false. It has been that way since it was introduced in ae08389, which set out to "prevent outdated props from triggering context errors" — a real problem the guard never actually prevented.That job is now done properly: a navigation whose props are discarded returns
ABANDONED, which #807 added along with the first test covering the behaviour. With the guard gone the parameter is unused, so it goes too.