🐛 Preserve tar symlinks on Python 3.14#2035
Merged
Merged
Conversation
Python 3.14 changes tarfile.extractall's default extraction filter to 'data' (PEP 706), which raises AbsoluteLinkError on absolute symlink entries. SDK/NDK/JDK extraction goes through buildops.file_extract; NDK r23b's macOS tarball is documented to contain absolute symlinks (android/ndk#1671), so `buildozer android debug` against that NDK version would fail on 3.14. Pass filter='fully_trusted' to extractall on Python 3.12+ via feature detection so 3.10/3.11 (where the kwarg does not exist) keep working unchanged. Add test_extract_tarball_preserves_symlinks which builds a tarball with relative and absolute symlinks and asserts both survive extraction. Without the filter argument the absolute-symlink assertion fails on 3.14 with tarfile.AbsoluteLinkError.
kuzeyron
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python 3.14 changes tarfile.extractall's default extraction filter to 'data' (PEP 706), which raises AbsoluteLinkError on absolute symlink entries. SDK/NDK/JDK extraction goes through buildops.file_extract; NDK r23b's macOS tarball is documented to contain absolute symlinks (android/ndk#1671), so
buildozer android debugagainst that NDK version would fail on 3.14.Pass filter='fully_trusted' to extractall on Python 3.12+ via feature detection so 3.10/3.11 (where the kwarg does not exist) keep working unchanged.
Add test_extract_tarball_preserves_symlinks which builds a tarball with relative and absolute symlinks and asserts both survive extraction. Without the filter argument the absolute-symlink assertion fails on 3.14 with tarfile.AbsoluteLinkError.