Choose a reasonable and valid number for the intent code#790
Open
matan-h wants to merge 2 commits into
Open
Conversation
Contributor
|
I am not 100% sure I understand the context on this code, so let me explain what I think:
My comments:
|
…s it would require a design change
Author
Contributor
|
Thanks. I understand now. [Just to be clear, I am not an official reviewer with merge rights. We'll need to wait for one of them.] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the
Android file chooseruse a reasonable and valid number in the intent code.As this Stack Overflow post explains, the maximum value for the requestCode is
2^16(65536).Previously, the code used arbitrary numbers (
123456and654321), which is making some phones encounter a Java Exception:java.lang.IllegalArgumentException: Can only use lower 16 bits for requestCode.