Draft
Conversation
core-ktx 1.17.0 requires compileSdk 36, which broke customers on compileSdk 35 via Gradle's transitive version resolution. Downgrade SDK modules to 1.16.0 and pin the sample app to 1.17.0 explicitly. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…emory leaks Adds defensive cleanup in destroyWebView() by removing the native bridge binding prior to webView.destroy(). Uses WebViewCompat.removeWebMessageListener when supported, falling back to removeJavascriptInterface for older WebView implementations. This addresses a reported memory leak where WebMessageListenerHolder retains KlaviyoWebView on some vendor implementations. Closes #430 | Part of MAGE-457 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Due Diligence
Release/Versioning Considerations
PatchContains internal changes or backwards-compatible bug fixes.MinorContains changes to the public API.MajorContains breaking changes.Changelog / Code Overview
Test Plan
Related Issues/Tickets